Type the client token's signed token as always present - #69
Merged
Merged
Conversation
The platform now guarantees `token` on POST /v1/client/tokens (a signing failure fails the mint), so drop the Optional and raise TokenCreateError if a response ever lacks it instead of handing callers None to branch on. Docs point frontends at `token`; `api_key` stays the opaque form for calls other than realtime and file uploads.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cecc889. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
tokens.create()now types the signedtokenas always present instead ofstr | None.api_keystays as the opaque form for calls other than realtime and file uploads.Changes
CreateTokenResponse.tokenisstr. A response without it raisesTokenCreateErrorinstead of returningNone.create_tokenexample point frontends attoken.Merge after api-platform#822 is deployed; before that, a mint whose signing failed would raise here instead of returning the opaque key.
Note
Medium Risk
This is a breaking typing/behavior change for integrators who branched on
token is None, and mint calls can fail hard if deployed before the platform always returns a signed token.Overview
tokens.create()now treats the signed JWT as mandatory, matching the platform contract after api-platform#822.CreateTokenResponse.tokenis typed asstr(notstr | None). If a successful HTTP response omitstoken, the client raisesTokenCreateErrorinstead of returningNone. Docstrings clarify thattokenis what browsers should use for realtime and uploads, whileapi_keyremains the opaqueek_...credential for other calls.The example and tests expect a JWT in every success payload, and a new test covers the missing-token error path.
Reviewed by Cursor Bugbot for commit cecc889. Bugbot is set up for automated code reviews on this repo. Configure here.