Repository navigation
Conversation
The php-fpm-8.6 base was built from the ondrej/php 8.6.0~rc3 packages (PHP API 20260924), which cannot load dd-trace-php builds for 8.6.0 GA (API 20261112). A new PPA build does not change the base content hash, so add a PHP_MIN_PACKAGE_VERSION floor to the php-fpm-8.6 target: it re-hashes the base and build.sh fails if the PPA still serves an older php8.6-fpm, so an rc build can never be published under the new tag. The floor check lives in the shared php-fpm build.sh and base Dockerfile, so every php-fpm base gets a new content tag. Regenerate base-images.lock.json and mirror_images.yaml; mirror_images.lock.yaml follows once the new bases are published.
Contributor
|
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 21 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: a56af5a | Docs | View more details | Give us feedback! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
php-fpm-8.6base still runs ondrej/php8.6.0~rc3(PHP API 20260924), which cannot load dd-trace-php built for 8.6.0 GA (API 20261112).A new PPA build does not change the base content hash, so the
php-fpm-8.6target gets aPHP_MIN_PACKAGE_VERSION = "8.6.0"floor: it re-hashes the base, andbuild.shfails if the PPA still serves an olderphp8.6-fpm, so an rc build is never published under the new tag.The check sits in the shared php-fpm
build.sh/base Dockerfile, so every php-fpm base gets a new tag (base-images.lock.jsonandmirror_images.yamlregenerated;mirror_images.lock.yamlfollows once the bases are published).php8.6-mongodbandphp8.6-rdkafkaare still not in the PPA for noble, so both stay excluded.