Repository navigation
Conversation
Exercise synchronous portable bootstrap, overlapping request contexts and dependency telemetry, configuration replacement, and explicit exposure tracking through OpenFeature. Keep activation gated pending a containing Node dependency update.
Contributor
|
|
4 of 5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Start the dedicated offline-provider harness discussed in openfeature-js-client #469. This is separate from #8267, which tests standalone precomputation helpers without registering a provider.
Changes
@datadog/openfeature-node-server/rules-baseddependency without importing or initializing the tracer, then registersDatadogCoreProviderthrough the real OpenFeature SDK.Activation And Scope
Keep this PR in draft. Node is
missing_featureuntil a containing Core/Node package dependency update is available in the test build. Other SDKs areincomplete_test_appbecause they do not implement this adapter.@slowavoids starting unsupported test apps in ordinary runs. No release version is assumed.The adapter can exercise the packaged Node dependency before
dd-traceexports the provider. It does not yet test tracer-owned evaluation hooks, uploaders, or intake delivery. Precomputed snapshot policy coverage and tracer integration are later additions; #8267 remains independent.For a containing custom Node build, using the repository's Python 3.12 runner:
Local Validation
d50b38c2e4040946af79ec3d19f6483589a7ce13(local package versions 3.5.0/2.8.0). These are unreleased local builds, not evidence that published packages contain the provider.dd-trace's package metadata solely as the dependency-resolution anchor. It ran the same test methods and unchanged child adapter, not the full container-backed parametric server or tracer wrapper../format.sh --checkpassed on a clean archive of the committed source, including Python typing/lint/formatting, import policy, manifest/YAML checks, ShellCheck, and both existing Node linter containers. JavaScript syntax checks passed for the new adapter and updated server.