Repository navigation
Conversation
With dd-trace-go's crash supervisor, the direct child of PID 1 in the Go parametric container is the supervisor, which does not run the tracer. Look at the children of PID 1 and their children, and use the one process that holds the tracer memfd.
Contributor
|
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
darccio
requested changes
Nov 19, 2026
A failed pgrep or find looked the same as a process without children or without a tracer memfd, so a real holder could drop out of the search. Treat only pgrep's no-match exit code as empty, assert on every other failure, and show the candidates when the holder count is wrong. Scan each candidate's memfds once.
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
darccio
approved these changes
Nov 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Go crashtracker in dd-trace-go moves from a child crash monitor to a supervisor: the original process stays the supervisor and runs the application as its child (DataDog/dd-trace-go#5905). After that change, the direct child of PID 1 in the Go parametric container is the supervisor, which does not run the tracer, so
test_process_discoveryfinds no tracer memfd there.Changes
For Go, the test now checks the direct children of PID 1 and their children, and uses the one process that holds the tracer memfd. It asserts that exactly one process holds it.
Checked locally with
./run.sh PARAMETRIC -L golang tests/parametric/test_process_discovery.py: 2 passed with golang@2.12.0 (child monitor) and 2 passed with the dd-trace-go#5905 branch (supervisor).Workflow
system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.system-tests-core(slack)🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟