Repository navigation
Use the CVE file override for Java and Python SCA tests - #8224
florentinl wants to merge 18 commits into
Conversation
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 9eda995 | Docs | View more details | Give us feedback! |
d247d83 to
fedcecf
Compare
## Description Enable SCA reachability in AWS Lambda. Requires the [Lambda startup change](DataDog/datadog-lambda-python#880); [system-tests coverage](DataDog/system-tests#8224) is separate. ## Testing 127 SCA tests, 12 regular/Lambda Flask telemetry cases, and five Lambda reachability checks pass on Colima. The Lambda reachability case fails with the old exclusion restored. Lint passes. ## Risks Lambda cold-start overhead is unmeasured. Co-authored-by: florentin.labelle <florentin.labelle@datadoghq.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e4fedfc9d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e4fedfc to
94f8739
Compare
cbeauchesne
left a comment
There was a problem hiding this comment.
tests/appsec/sca/<lang>/advisories.json are part of scenario definition. As the content is quite small, can you move it as bare python inside utils/_context/_scenarios/appsec.py ?
With that, no need to modify libraries_and_scenarios, and no risk to skip a scenario on a later PR.
4b5b377 to
46c433e
Compare
Keep the tracer-native catalogs in appsec.py and generate the read-only JSON files for the existing regular and Lambda scenarios. Let the Lambda SCA scenario select its libraries without a separate CI rule.
46c433e to
9182df2
Compare
Avoid the prohibited cross-scenario import. Keeping each catalog in its own scenario definition also lets CI select the right scenario for fixture edits without changing selection rules.
The three production Flask variants use ddtrace 4.17.1, which predates the catalog override in dd-trace-py #21534. All three development variants pass with 4.18.0-rc1; use that as the minimum version.
Description
Exercise SCA reachability with language-native synthetic advisories supplied through
_DD_APPSEC_SCA_CVE_FILE, without modifying installed tracer files or Java bootstrap options.Manifests enable all five tests for Java and Java Lambda from
v1.69.0-SNAPSHOT, which includes dd-trace-java#13285, and regular Python fromv4.17.0-rc1. Test activation depends on the manifests rather thanSYSTEM_TESTS_DEV_MODE. Python Lambda remains gated on dd-trace-py#21366 and datadog-lambda-python#880.Testing
All 130 related manifest, scenario and CI-selection tests pass, along with repository formatting and checks. Another 120 activation checks verify manifest resolution for supported and unsupported builds with dev mode unset, false and true.
CI on the preceding head
84680b6abpassed all five SCA tests for both Java and Java Lambda using master artifact1.69.0-SNAPSHOT+1724636081. The final Python activation-guard removal is covered by the local checks above; end-to-end CI for that update is pending.