Conversation
This was referenced Sep 18, 2026
This comment has been minimized.
This comment has been minimized.
Reserve an 8 MiB stack for the MSVC pup executable. The debug command router exceeds the default 1 MiB reserve, so real-binary integration tests were aborting before reaching any command. Add startup success/error smoke tests and remove colons from fixture config directory names so they are valid on Windows. Keep all CI tests enabled and preserve the existing build and test profiles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
idp entities queryuseful for connected context and bounded inventories while preserving the evidence needed to interpret the answer. Select related attributes and edge measurements, scope supported measurements, and continue the exact effective query through an executable argument array.Changes
kinds describeoutput. Reuse the sharedquery/list/searchoption parsing. Preserve returned identity attributes, edge metadata, nulls, explicit empty relationships, and server warnings; distinguish missing/malformed evidence from absence.--from/--to, day/week lookbacks, and schema-supported--scope. Returnnext_request.argspreserving effective fields, time bounds, scopes, sorting, matching mode, org profile, and cursor. Credentials remain in the caller's environment.--max-results(1–10,000), with a smaller final request to fit the budget, explicit stop reasons, and failures for repeated cursors, empty nonterminal pages, oversized responses, or later request failures. Default queries still fetch one page; automatic paging conflicts with--raw.list/search.These controls share query preparation and continuation; keeping them together ensures a continued inventory uses the same projections and measurement context.
Validation
cargo clippy --locked --all-targets -- -D warnings,cargo fmt --check,git diff --check, and skill validation passed.cargo auditreports four existing findings in the unchanged lockfile: h2 (RUSTSEC-2026-0258), rustls (RUSTSEC-2026-0285), and two rsa versions (RUSTSEC-2023-0071). No dependencies changed. Tests ran serially due to existing shared-environment races elsewhere.Companion PRs
These PRs each build independently against
main; their changes also merge cleanly together. The combined tree passed 2,032 unit tests, all 20 real-binary tests, Clippy, formatting, and skill validation.