Skip to content

chore: install libclang in order to avoid compilation problems - #2909

Open
hoolioh wants to merge 3 commits into
mainfrom
julio/install-libclang-dev
Open

hoolioh wants to merge 3 commits into
mainfrom
julio/install-libclang-dev

Conversation

@hoolioh

@hoolioh hoolioh commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

libprofiling-heap-sampler was failing to compile in another branch because the runner lacked some headers. This started to happen because ubuntu-latest started to ship Ubuntu 26.04.

@hoolioh
hoolioh requested review from a team as code owners November 20, 2026 14:08
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T14:09:55.672703Z d7aac3b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@hoolioh hoolioh changed the title chore: install libclang in order to avoid problems compilation problems chore: install libclang in order to avoid compilation problems Nov 20, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 84.87% (-0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 96c3616 | Docs | View more details | Give us feedback!

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@pr-commenter

pr-commenter Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Benchmarks

Comparison

Benchmark execution time: 2026-11-20 14:41:53

Comparing candidate commit 96c3616 in PR branch julio/install-libclang-dev with baseline commit 396d962 in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 6 performance regressions! Performance is the same for 162 metrics, 9 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:obfuscate_span/cc=false rules=false/wall_time

  • 🟥 execution_time [+295.526ns; +312.170ns] or [+10.965%; +11.582%]

scenario:obfuscate_span/cc=false rules=true/wall_time

  • 🟥 execution_time [+362.255ns; +379.138ns] or [+5.011%; +5.245%]

scenario:obfuscate_span/cc=true rules=false/wall_time

  • 🟥 execution_time [+292.637ns; +319.053ns] or [+6.974%; +7.604%]

scenario:span_pool_v1/wall_time/1x10/allocating

  • 🟥 execution_time [+103.053ns; +104.334ns] or [+4.217%; +4.269%]
  • 🟥 throughput [-167572.725op/s; -165513.722op/s] or [-4.095%; -4.045%]

scenario:vec_map/dedup/dup_1_in_2/128

  • 🟥 execution_time [+162.643ns; +274.354ns] or [+4.096%; +6.910%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:obfuscate_span/cc=false rules=false/allocated_bytes

  • unstable execution_time [-0.001ns; +0.001ns] or [+555.735%; -555.735%]

scenario:span_pool/allocated_bytes/1x10/pooled

  • unstable execution_time [-3.833µs; +1.247µs] or [-150.179%; +48.846%]
  • unstable throughput [-316666888.199op/s; -2941060.727op/s] or [-150.789%; -1.400%]

scenario:span_pool/allocated_bytes/20x100/pooled

  • unstable execution_time [-119.631µs; +148.231µs] or [-8.098%; +10.034%]
  • unstable throughput [-130920.154op/s; +111199.598op/s] or [-9.592%; +8.147%]

scenario:span_pool_v1/allocated_bytes/1x10/pooled

  • unstable execution_time [-166.545ns; +689.949ns] or [-10.759%; +44.573%]
  • unstable throughput [-2961117.949op/s; +812733.806op/s] or [-41.965%; +11.518%]

scenario:span_pool_v1/allocated_bytes/20x100/pooled

  • unstable execution_time [-136.325µs; +31.125µs] or [-9.847%; +2.248%]
  • unstable throughput [-35734.209op/s; +145400.239op/s] or [-2.461%; +10.012%]
Benchmark execution time: 2026-11-20 14:44:06

Comparing candidate commit 96c3616 in PR branch julio/install-libclang-dev with baseline commit 396d962 in branch main.

📊 Benchmarking dashboard

Found 1 performance improvements and 2 performance regressions! Performance is the same for 103 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:single_flag_killswitch/rules-based

  • 🟥 execution_time [+9.029ns; +9.827ns] or [+4.563%; +4.966%]

scenario:thread_cpu/alloc_free/system/4096

  • 🟥 execution_time [+14.819ns; +15.024ns] or [+16.238%; +16.463%]

scenario:thread_cpu/profiler_attached/fast_path_system/4096

  • 🟩 execution_time [-13.397ns; -13.256ns] or [-11.294%; -11.175%]

Benchmark execution time: 2026-11-20 14:47:53

Comparing candidate commit 96c3616 in PR branch julio/install-libclang-dev with baseline commit 396d962 in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 2 performance regressions! Performance is the same for 72 metrics, 24 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:trace_buffer/8_senders/no_delay

  • 🟥 execution_time [+281.839µs; +322.926µs] or [+4.999%; +5.728%]
  • 🟥 throughput [-69420.175op/s; -60570.168op/s] or [-5.436%; -4.743%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:datadog_sample_span/complex_rule_matching/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+561.750%; -558.575%]

scenario:datadog_sample_span/complex_rule_partial_match/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+546.985%; -551.636%]

scenario:datadog_sample_span/many_attributes_tag_rule/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+551.886%; -553.927%]

scenario:datadog_sample_span/multiple_rules_first_match/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+557.408%; -556.523%]

scenario:datadog_sample_span/multiple_rules_last_match/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+548.949%; -552.553%]

scenario:datadog_sample_span/name_pattern_rule_matching/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+552.108%; -554.031%]

scenario:datadog_sample_span/name_pattern_rule_not_matching/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+564.491%; -559.876%]

scenario:datadog_sample_span/parent_not_sampled_short_circuit/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+556.659%; -556.170%]

scenario:datadog_sample_span/parent_sampled_short_circuit/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+555.550%; -555.648%]

scenario:datadog_sample_span/resource_pattern_rule_matching/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+548.494%; -552.340%]

scenario:datadog_sample_span/resource_pattern_rule_not_matching/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+558.623%; -557.096%]

scenario:datadog_sample_span/root_span_no_rules/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+555.735%; -555.735%]

scenario:datadog_sample_span/service_rule_matching/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+548.888%; -552.524%]

scenario:datadog_sample_span/service_rule_not_matching/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+553.474%; -554.672%]

scenario:datadog_sample_span/tag_rule_matching/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+548.630%; -552.404%]

scenario:datadog_sample_span/tag_rule_not_matching/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+558.129%; -556.863%]

scenario:glob_matcher/ascii_case_insensitive_match/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+556.341%; -556.020%]

scenario:glob_matcher/ascii_exact_match/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+544.928%; -550.679%]

scenario:glob_matcher/ascii_exact_miss/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+547.442%; -551.849%]

scenario:glob_matcher/ascii_wildcard_backtrack_match/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+561.656%; -558.531%]

scenario:glob_matcher/ascii_wildcard_heavy_backtrack/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+555.735%; -555.735%]

scenario:glob_matcher/ascii_wildcard_question_match/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+554.097%; -554.964%]

scenario:glob_matcher/ascii_wildcard_star_match/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+556.556%; -556.122%]

scenario:glob_matcher/star_short_circuit/allocated_bytes

  • unstable execution_time [-0.000ns; +0.000ns] or [+555.927%; -555.825%]

Candidate

Omitted due to size.

Baseline

Omitted due to size.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants