Repository navigation
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 491169c | Docs | View more details | Give us feedback! |
Codeowners resolved asResolved from the full PR diff against |
Dependency direction analysis
|
d5ee1d8 to
491169c
Compare
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
More details
Weighting sampled exceptions by the configured interval matches the intended exception-volume estimator. No reportable defect emerged from static review; runtime behavior was not exercised.
🤖 Bits Code Review · Commit 491169c
BenchmarksBenchmark execution time: 2026-11-20 04:34:55 Comparing candidate commit 491169c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 603 metrics, 10 unstable metrics, 1 flaky benchmarks without significant changes.
|

Description
Exceptions get sampled with Poisson sampling with interval
R. Therefore, when reporting, we should scale byR.Some different options:
-N(1 - 1/R) = -N, No variance, but reports raw sample count, ~1/Rth of realityC): The bias is~-R, low, bounded variance, undercounts tail after last sampleR(this PR): No bias,~O(R * N)variance, unbiased sinceE[k·R] = NNote: (2)'s bias is negligible compared to variance savings as N grows, but (3) is more statistically sound.
Testing
Unit test for upscaling
Risks
Additional Notes