Repository navigation
Conversation
…art_ng multipart 0.18 is unmaintained (RUSTSEC-2023-0050) and was ignored in deny.toml. multipart_ng is a drop-in fork of multipart 0.18.0 with the same API; the dependency is renamed, so the AppSec code is unchanged. Remove the advisory ignore and regenerate LICENSE-3rdparty.csv.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🔵 Needs a closer look
The new multipart_ng and buf_redux_ng forks process untrusted AppSec request bodies, but their sources are absent from the checkout, requiring independent verification of source equivalence and dependency provenance.
No open issues 🎉
What changed in this PR
Replaces the unmaintained multipart parser used by AppSec with multipart_ng, preserving the existing import name and avoiding application code changes.
Changes:
- Switches to
multipart_ng0.18.1 and itsbuf_redux_ngdependency. - Removes the obsolete RUSTSEC-2023-0050 advisory exception.
- Updates third-party license attribution for both replacement packages.
| File | Description |
|---|---|
bottlecap/LICENSE-3rdparty.csv |
Updates package names, repository URLs, and author attribution. |
bottlecap/deny.toml |
Removes the unmaintained multipart advisory exception. |
bottlecap/Cargo.toml |
Aliases multipart_ng as multipart, retaining existing feature settings. |
bottlecap/Cargo.lock |
Records replacement packages, versions, checksums, and dependency references. |
Review effort: Balanced
Problem
multipart0.18 is unmaintained (RUSTSEC-2023-0050).bottlecap/deny.tomlignores the advisory with the note "no maintained replacement is chosen yet".This PR
multipart_ng, a maintained fork ofmultipart0.18.0 with the same API. Disclosure: I maintain it. The dependency is renamed (multipart = { package = "multipart_ng", … }), soappsec/processor/context.rsdoes not change.multipart0.18.0 and its dependencybuf_redux0.8.4 (replaced bybuf_redux_ng). The only difference is the removed trailing semicolon in three macros, which fixes a future-incompatibility warning. You can check this by diffing thesrc/directories of the published crates.deny.tomland regeneratesLICENSE-3rdparty.csvwithdd-rust-license-tool write.Cargo.lockonly swaps these two packages.Testing
Test 1: cargo deny
Steps
cargo deny --locked checkinbottlecap/Result
advisories, bans, licenses and sources are ok. The remaining warnings are the same as on
main.Test 2: CI
Steps
Result
Build All, Test Suite, Check, Clippy, Audit, Lockfile Scan, Unused Dependencies and Valid LICENSE-3rdparty.csv pass.
No Jira ticket, this is an external contribution.