Skip to content

fix(deps): replace unmaintained multipart with maintained fork multipart_ng - #1532

Open
CarloTUM wants to merge 1 commit into
DataDog:mainfrom
CarloTUM:multipart-ng
Open

CarloTUM wants to merge 1 commit into
DataDog:mainfrom
CarloTUM:multipart-ng

Conversation

@CarloTUM

Copy link
Copy Markdown

Problem

multipart 0.18 is unmaintained (RUSTSEC-2023-0050). bottlecap/deny.toml ignores the advisory with the note "no maintained replacement is chosen yet".

This PR

  • Switches to multipart_ng, a maintained fork of multipart 0.18.0 with the same API. Disclosure: I maintain it. The dependency is renamed (multipart = { package = "multipart_ng", … }), so appsec/processor/context.rs does not change.
  • Apart from comments, the library code is identical to multipart 0.18.0 and its dependency buf_redux 0.8.4 (replaced by buf_redux_ng). The only difference is the removed trailing semicolon in three macros, which fixes a future-incompatibility warning. You can check this by diffing the src/ directories of the published crates.
  • Removes the RUSTSEC-2023-0050 ignore from deny.toml and regenerates LICENSE-3rdparty.csv with dd-rust-license-tool write. Cargo.lock only swaps these two packages.

Testing

Test 1: cargo deny

Steps

  1. cargo deny --locked check in bottlecap/

Result

advisories, bans, licenses and sources are ok. The remaining warnings are the same as on main.

Test 2: CI

Steps

  1. Ran the Bottlecap (Rust) workflow on my fork: https://github.com/CarloTUM/datadog-lambda-extension/actions/runs/44518807796

Result

Build All, Test Suite, Check, Clippy, Audit, Lockfile Scan, Unused Dependencies and Valid LICENSE-3rdparty.csv pass.

No Jira ticket, this is an external contribution.

…art_ng

multipart 0.18 is unmaintained (RUSTSEC-2023-0050) and was ignored in
deny.toml. multipart_ng is a drop-in fork of multipart 0.18.0 with the
same API; the dependency is renamed, so the AppSec code is unchanged.
Remove the advisory ignore and regenerate LICENSE-3rdparty.csv.
@CarloTUM
CarloTUM requested a review from a team as a code owner November 19, 2026 12:06
@CarloTUM
CarloTUM requested review from lym953 and a balanced review from Copilot November 19, 2026 12:06
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T12:08:07.810701Z 09d20b0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The new multipart_ng and buf_redux_ng forks process untrusted AppSec request bodies, but their sources are absent from the checkout, requiring independent verification of source equivalence and dependency provenance.

No open issues 🎉

What changed in this PR

Replaces the unmaintained multipart parser used by AppSec with multipart_ng, preserving the existing import name and avoiding application code changes.

Changes:

  • Switches to multipart_ng 0.18.1 and its buf_redux_ng dependency.
  • Removes the obsolete RUSTSEC-2023-0050 advisory exception.
  • Updates third-party license attribution for both replacement packages.
File Description
bottlecap/​LICENSE-3rdparty.csv Updates package names, repository URLs, and author attribution.
bottlecap/​deny.toml Removes the unmaintained multipart advisory exception.
bottlecap/​Cargo.toml Aliases multipart_ng as multipart, retaining existing feature settings.
bottlecap/​Cargo.lock Records replacement packages, versions, checksums, and dependency references.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants