Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle Directory fonts for local loading
Replace the root layout's Google Fonts loader with
next/font/local, using bundled Plus Jakarta Sans and Source Code Pro variable fonts. This removes the layout's build-time dependency on fetching those fonts from Google.The files are under
reference-implementations/dacs-directory/:app/layout.tsxloadsapp/fonts/PlusJakartaSans-variable.ttfandapp/fonts/SourceCodePro-variable.ttf, using--font-jakartawith weight400 700and--font-scpwith weight400 600.app/fonts/contains both font files, their SIL OFL 1.1 license files, and a README with the two font hashes.test/offline-fonts.test.mjschecks that the layout has nonext/font/googleimport, checks the requested weight ranges against the bundled font axes, and checks the adjacent license files.How to check:
cd reference-implementations/dacs-directory && node --test test/offline-fonts.test.mjsCloses #144
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.