Repository navigation
Directory: describe recipe snapshots as operator-trusted config and log their source - #261
Merged
randomblocker merged 1 commit intoNov 6, 2026
Conversation
…e, test the signer roster source DACS_RECIPE_SNAPSHOTS is operator-trusted configuration and is unauthenticated until the Standard defines a steward key. The resolver comment, README and SPEC_PIN now say so instead of calling it authenticated. The first resolution of a configuration value logs one line with the source name and the snapshot and trusted-signer counts, never keys or contents. A test shows the trusted signer roster comes only from DACS_RECIPE_SNAPSHOTS: a result, request field or fetched document that carries its own signer list adds nothing. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolveConfiguredRecipeSnapshotaccepts the recipe registry snapshots inDACS_RECIPE_SNAPSHOTSafter checking only their shape. Its doc comment called them "Operator-authenticated", but nothing authenticates them. The pinned Standard defines no steward key yet, so there is nothing to verify a signed index against. This PR therefore corrects the claim instead of adding verification:SPEC_PINnow say the snapshots are operator-trusted configuration, unauthenticated until the Standard defines a steward key.DACS_RECIPE_SNAPSHOTS: <n> snapshots, <m> trusted signers, so an operator can see that snapshots are configured and how many snapshots and signers they hold (the line names no version or digest). The resolver has no production caller yet, so the line appears once a caller is wired in. No keys or snapshot contents are logged.test/recipe-snapshot.test.ts:trustedResultSignersroster comes only from the env var. A signer list carried by a recipe result, the requirement, a fetched document or the snapshot object adds nothing, and a key outside the env roster is refused.Verifying a signed snapshot index (a steward key, a detached index with per-snapshot hashes) is a later change that waits on the Standard defining a steward key.
Full directory suite: 1677 pass, 0 fail; typecheck clean.
Closes #156
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.