Skip to content

Browser source-row links target a manifest too large for GitHub line rendering #227

Open

Description

@realmarcin

Independent review of PR #225 at 0c21d316fac03ee92ee337c64d64481e95653878 found that the links labeled “Exact public sample row” cannot expose the promised row.

src/edgemech/site.py:217–218 and src/edgemech/site_assets/browser.js:125–127 construct GitHub blob URLs with line anchors into the 7,851,103-byte sample manifest. The immutable source URL serves GitHub’s file-too-large page, with rawLines: null; the line fragment therefore has no rendered target.

This breaks the browser’s direct provenance handoff even though the source commit, hash and original occurrence are preserved correctly.

Acceptance:

  • Provide an addressable source-row view, or accurately label a pinned source-manifest download and visibly retain the source line and hash.
  • Apply the same behavior to interactive details and the no-JavaScript catalogue.
  • Verify a real sample source link resolves to the advertised artifact and that no link promises an exact row that GitHub cannot display.

Severity: P2. Found in a separate read-only adversarial review on 2026-11-19 America/Los_Angeles. Fix in PR #225 before proposing merge.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions