Skip to content

Fail closed on missing infrastructure config and unverified analytics sidecar bindings #621

Closed

Description

@realmarcin

Found during adversarial review of #618.

  1. scripts/gaps/build.py checks args.infrastructure.is_file() when --without-infrastructure is not set, which would silently drop _fleet/infrastructure.json (EdgeMech) if the file were missing rather than failing closed.
  2. assets/gaps/browser.js (loadAnalytics) only checks doc.terms_sha256 !== manifest.terms.sha256 when doc.terms_sha256 is truthy, does not validate doc.embedding_inputs_sha256 when embedding_bridges is present, and load() does not reset analytics-status visibility.
  3. scripts/gaps/analytics.py (build_analytics_document) should verify build_id, terms_sha256, and contains_unlisted_mech across term_document and embedding_document inputs, slice kept_bigrams = bigrams[:25] consistently so ranks 26–30 do not suppress unigrams while being dropped, guard duplicate-prompt button ellipses/labels, and test entity_cohesion (>= 5 postings) and mismatched inputs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions