Skip to content

Retirement helper timeout can release the lease while deletion continues #608

Closed

Description

@realmarcin

Read-only review of the uncommitted retirement helper prepared for PR #603 found that scripts/adhoc/retire_site_projection_603.py applies a 60-second subprocess.check_output timeout to guarded_rm.sh.

That shell launches rm -rf as a child. On timeout, Python kills only the shell; the deletion child can continue after the wrapper raises and releases its site lease. The shell may never write its completion receipt. This violates the intended guarantee that destructive work remains inside the held lease.

Run the destructive helper in its own process group and ensure all descendants are terminated and reaped on timeout or interruption before releasing the lease. Keep read-only command limits separate. Add a distinguishing regression exercising a delayed child and demonstrate that the old behavior fails.

Priority: P2. Fix in PR #603 before using the retirement helper. No deletion has been attempted.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions