Generate reviewable evidence inventories instead of pinned counts - #355
Merged
Merged
Conversation
…entories # Conflicts: # Storybook/scripts/verify-storybook-indexes.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a story, part or export no longer means hand-editing a count in a verifier. The verifiers compare against committed inventories of names instead, so a failure says exactly what was added or removed. Pinned counts broke CI three times.
Changed
Source/scripts/*-inventory.json,Storybook/scripts/*-inventory.json) instead of fixed counts. When something is added or removed, the failure names it and says how to update the inventory. (Generate reviewable evidence inventories instead of hardcoded counts #217)yarn generate-inventoriesto refresh every inventory after a deliberate change, then review the diff like any other change. CI only compares; it never regenerates. (Generate reviewable evidence inventories instead of hardcoded counts #217)Closes #217.