Let hosts theme the canvas minimap grid and default item color - #352
Merged
Merged
Conversation
The minimap drew its dot grid and its uncolored items from inline styles, so a host could only change them by changing surface-border and the text color for everything else too. Two component tokens, --cratis-canvas-minimap-grid-color and --cratis-canvas-minimap-item-color, now take precedence. They are deliberately left undefined and read with a fallback, so they resolve on the minimap itself and follow a dark subtree; the fallbacks are today's values, so nothing changes until a host sets them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
--cratis-canvas-minimap-grid-colorand--cratis-canvas-minimap-item-colortheme the Canvas minimap dot grid and items that have nocolorof their own. Both fall back to the current colors, so the minimap looks the same until you set them.