Let hosts replace canvas control icons and opt out of viewport insets - #351
Merged
Merged
Conversation
The control bar drew a fixed set of icons, so an application using its own icon set had controls that did not match the rest of its interface. controlsIcons (icons on CanvasControls) replaces any subset of the minimap, zoom and help glyphs; the accessible names still come from the labels. The bar also always stepped aside by --canvas-viewport-left/right, which moves it twice when the host has already shifted the canvas by that inset. controlsFollowViewportInsets (followViewportInsets) turns the offset off; it stays on by default, so nothing changes for existing hosts.
The --canvas-viewport-left/right custom properties were read by the controls but never documented; describe them together with the switch that turns them off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
controlsIconsonCanvas(iconsonCanvasControls) replaces any of the minimap, zoom-out, zoom-in and help glyphs with your own icons. Unset fields keep the built-in icons, and the accessible names still come fromcontrolsLabels.controlsFollowViewportInsetsonCanvas(followViewportInsetsonCanvasControls) turns off the offset by--canvas-viewport-left/--canvas-viewport-right, for hosts that already move the canvas by that inset. It defaults totrue, so existing canvases are unchanged.--canvas-viewport-leftand--canvas-viewport-rightcustom properties the controls read are now documented.