Fix stepper step callbacks, PivotViewer grouping and transitions, and non-modal ChatSidebar rendering - #345
Merged
Merged
Conversation
The story did not reproduce the #236 blank state on the original code, and it required a test-only function on the shipped Pixi canvas element. The viewport recovery is covered by the syncSpritesToViewport and animation specs.
… into fix/patch-batch-4151
…fix/patch-batch-4151
This was referenced Sep 26, 2026
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
CommandStepperandStepperCommandDialognow callonChangeStep({ index })once for every accepted move to a different step: header clicks, Previous, and Next. Previous and Next never reported a change before, and a header click reported one even when the move was then rejected. (CommandStepper/StepperCommandDialog lack ARIA tab semantics and a step-changed callback for Next/Previous #249)aria-labelledby. If you passpt.header.id, your id is kept and the panel keeps its text label. The wizard stays an ordered list of steps rather than ARIA tabs. (CommandStepper/StepperCommandDialog lack ARIA tab semantics and a step-changed callback for Next/Previous #249)undefined, and infers each column's type from its first non-missing value. Missing numbers sort last. Because of this, a numeric column whose first value is missing is now treated as numeric, so a categorical selection on it no longer narrows the cards, as for every other numeric column. (Honor PivotViewer dimension grouping contracts and localize toolbar copy #334)formatValueto column labels andsortto column order. Changing either no longer re-runs the grouping. (Honor PivotViewer dimension grouping contracts and localize toolbar copy #334)ChatSidebarcan now be rendered open on the server. It portals after mount into theCratisComponentsProvideroverlay container, and falls back todocument.bodywhen there is none. (Non-modal ChatSidebar breaks server rendering and skips its open/close animation #339)ChatSidebarnow plays the same open and close animation as the modal one, and skips it when the user prefers reduced motion. (Non-modal ChatSidebar breaks server rendering and skips its open/close animation #339)Changed
yarn ciinSourcenow also runs the public API TSDoc check and the packed-archive CSS budget check, which previously ran only in GitHub CI.