Repository navigation
Conversation
Contributor
|
(conflict) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manual Init marker on rules such as vector::emplace_back was used to encode semantic information about the rule: the forward pack is used to construct an element type.
For automatically generated rules this is not a good approach. The signature does not tell how forwarded arguments are used, this information exists as text in the description of the standard, for example:
Inserts a new element into the container constructed in-place with the given args, if there is no element with the key in the container. The constructor of the new element (i.e. std::pair<const Key, T>) is called with exactly the same arguments as supplied to emplace, forwarded via std::forward(args)....
This PR moves the Init marker in the Rust translation:
cpp_type has no semantic meaning for the rule, it expands to the second argument, i.e.
(Value<T1>, Value<T2>).I also added rules for std::any which builds a
decay_t<T>using the forwarded arguments. I wanted to make sure that this also works.