Skip to content

Fixed lint-staged hook to only check staged files - #1824

Merged
david-yz-liu merged 1 commit into
masterfrom
lint-staged-changed-files
Nov 1, 2026
Merged

david-yz-liu merged 1 commit into
masterfrom
lint-staged-changed-files

Conversation

@david-yz-liu

@david-yz-liu david-yz-liu commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Proposed Changes

The lint-staged pre-commit hook was formatting and linting far more than the files in each commit:

  • "*": "pnpm prettier --ignore-unknown --write" ran the prettier package script (prettier --write .), so every commit ran Prettier over the whole repository. Unrelated files (e.g. pnpm-lock.yaml) were left modified in the working tree after committing.
  • "*.{js,ts,tsx}": "pnpm run eslint --cache --fix js" ran the eslint script (eslint --fix js) with another js argument, so it linted the whole js/ directory.

Changes:

  • The lint-staged commands now call prettier, eslint and stylelint directly, so lint-staged passes only the staged files. The stylelint entries already behaved correctly and were changed for consistency. The hlint/fourmolu entries are unchanged.
  • Added pnpm-lock.yaml to .prettierignore, since the lockfile is generated by pnpm and shouldn't be reformatted.
  • Removed a trailing space in style/app.scss, which the previous whole-repository Prettier run had picked up.
Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration) X

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CI checks have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

How this was verified (no automated tests apply to hook configuration):

  • Ran pnpm exec lint-staged with one badly formatted staged JS file and one badly formatted unstaged JS file. Only the staged file was formatted and linted.
  • prettier --file-info pnpm-lock.yaml reports "ignored": true.
  • This PR's own commit went through the new hook, and the working tree was clean afterwards.

🤖 Generated with Claude Code

The Prettier and ESLint lint-staged commands invoked package.json scripts
that already target the whole repository (`prettier --write .`) or the
whole `js/` directory, so every commit reformatted and linted unrelated
files. Call the tools directly so lint-staged passes only staged files.

Also added pnpm-lock.yaml to .prettierignore and removed a trailing space
in style/app.scss.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 41323639772

Coverage remained the same at 60.654%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 4308
Covered Lines: 2675
Line Coverage: 62.09%
Relevant Branches: 1014
Covered Branches: 553
Branch Coverage: 54.54%
Branches in Coverage %: Yes
Coverage Strength: 158.61 hits per line

💛 - Coveralls

@david-yz-liu
david-yz-liu merged commit 013156e into master Nov 1, 2026
3 checks passed
@david-yz-liu
david-yz-liu deleted the lint-staged-changed-files branch November 1, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants