Repository navigation
lock(tui): COR-18/225/227/228 theme, fork, init, hooks - #71
Conversation
1 similar comment
Designer cli HOLD on #71: capture handoff-confirm at 40×12 as well. Co-authored-by: Mathis <echobt@users.noreply.github.com>
2 similar comments
Greptile SummaryThis PR adds locked terminal UI scenes for theme selection, session forking, initialization, custom commands, hooks, and Cortex Cloud handoff. It also registers Confidence Score: 5/5Safe to merge; there are no outstanding blocking issues. No accepted new findings or outstanding previous findings remain. Reviews (10): Last reviewed commit: "fix(tui): load live cloud agents on /han..." | Re-trigger Greptile |
Designer cli HOLD on #71: capture handoff-confirm at 40×12 as well. Co-authored-by: Mathis <echobt@users.noreply.github.com>
fe9a4ab to
8e00fec
Compare
3 similar comments
Add runtime lock boards for COR-18, COR-225, COR-227, and COR-228. Skip COR-226 share/unshare. Leave existing designer PNGs untouched. Co-authored-by: Mathis <echobt@users.noreply.github.com>
Designer cli HOLD on #71: capture handoff-confirm at 40×12 as well. Co-authored-by: Mathis <echobt@users.noreply.github.com>
Register /handoff, use HookEvent names, built-in AGENTS.md copy, and drop the stale narrow jobs.png. Co-authored-by: Mathis <echobt@users.noreply.github.com>
Keep never-consent visible on the narrow hooks picker. Co-authored-by: Mathis <echobt@users.noreply.github.com>
Show built-in template on the narrow /init picker so the runtime PNG actually changes. Co-authored-by: Mathis <echobt@users.noreply.github.com>
Add IBM Plex designer PNGs plus txt dumps so OCR matches built-in project template and pre_tool_use / session_end. Co-authored-by: Mathis <echobt@users.noreply.github.com>
Open the Cortex Cloud vs stay picker instead of the unsupported async-command path. Stay keeps the CLI; Cloud points at /jobs. Co-authored-by: Mathis <echobt@users.noreply.github.com>
Keep 95 wide / 49 narrow after merging Computer boards with designed scenes. Co-authored-by: Mathis <echobt@users.noreply.github.com>
f9af608 to
2cd008d
Compare
Designer cli LOCK — COR-18 / 225 / 227 / 228Verdict: LOCK (chrome lockable) on head QA runtime 40×12 + 120×40:
Note: Greptile still flags Alexa (@alexa) chrome is lockable for these scenes. |
Move /handoff confirm handling out of modal.rs so the file stays under the line and complexity targets. Co-authored-by: Mathis <echobt@users.noreply.github.com>
Selecting Cortex Cloud lists or creates Code sessions instead of opening the empty local jobs picker. Co-authored-by: Mathis <echobt@users.noreply.github.com>
|
Greptile (@greptileai) |
Co-authored-by: Mathis <echobt@users.noreply.github.com>
Co-authored-by: Mathis <echobt@users.noreply.github.com>
* feat(tui): residual lock chrome for shortcuts, goal, composer Interactive /shortcuts sheet, /goal status polish, composer hover and Alt+Enter, denser diff/markdown locks, and distinct thinking/stop/todos question states. COR-7/9/10/14/15 only — not offline or 429 chrome. Co-authored-by: Mathis <echobt@users.noreply.github.com> * chore(tui): recapture lock v2 runtime pngs Regenerate 36×40×12 and 82×120×40 unique hashes via scripts/render-tui-lock-v2.sh for COR-7/9/10/14/15 chrome. Co-authored-by: Mathis <echobt@users.noreply.github.com> * feat(tui): lock /model effort radios and custom labels Align /model list and High/Medium/Low effort rows with lock v2 copy, gutter, and footers. Enter chooses then applies; custom providers stay Cortex-safe. COR-13 residual only. Co-authored-by: Mathis <echobt@users.noreply.github.com> * chore(tui): recapture /model effort lock pngs Runtime 40×12 and 120×40 hashes after COR-13 /model residual. Co-authored-by: Mathis <echobt@users.noreply.github.com> * feat(tui): lock farm modes, mcp, hover, resume, sandbox Document Esc/Ctrl+C/Shift+Tab/Ctrl+x/F2, polish Plan/Ask/Agent and /mcp/resume/clear/sandbox-deny chrome. Permission-prompt radios unchanged. Co-authored-by: Mathis <echobt@users.noreply.github.com> * chore(tui): recapture farm lock pngs Runtime 40x12 and 120x40 proofs for mode, mcp, resume, clear, sandbox. Co-authored-by: Mathis <echobt@users.noreply.github.com> * fix(tui): split lock modules and keep custom models distinct Extract MCP panel and session banner helpers so lock files stay under the 1000-line source policy. Split keyboard/mouse handlers to cap complexity. Third-party /model rows keep unique Custom labels without vendor names. Co-authored-by: Mathis <echobt@users.noreply.github.com> * fix(tui): split key handlers after rebase onto main Keep interactive, overlay, and selection dispatch under the source policy complexity cap now that #67 is on main. Co-authored-by: Mathis <echobt@users.noreply.github.com> * fix(tui): align inline picker clicks with chrome MCP, permissions, clear-confirm, and resume paint banner/search rows above options. Hit-testing now uses that same origin so mouse selects the visible row. Co-authored-by: Mathis <echobt@users.noreply.github.com> * fix(tui): resume picker ux contract and keyboard coverage /sessions opens the inline resume list, not a modal stack. Cover Ctrl+x, Shift+Tab, palette arrows, and Esc cancel in verify_mcp. Co-authored-by: Mathis <echobt@users.noreply.github.com> * fix(tui): match picker clicks when banners crowd the stack On short terminals the update and opt-in banners collapse the transcript, so the picker is no longer composer_y minus its height. Click zones now use the same stack origin as paint. Co-authored-by: Mathis <echobt@users.noreply.github.com> * fix(tui): rebase lock chrome onto main picker and overlay fixes Keep lock PNG blobs from #67/#69/#70. Wire TodoWrite into the live checklist, clamp compact shortcut hits, and drop stale stopped copy. Co-authored-by: Mathis <echobt@users.noreply.github.com> * fix(tui): drop source-policy complexity after main rebase Split picker-row painting and custom interactive footers so the rebase onto #69/#70 stays at the main complexity baseline. Co-authored-by: Mathis <echobt@users.noreply.github.com> * fix(tui): apply TodoWrite checklist without dropping the queue Apply live Working n/m from spawn args and completion output so a full tool-event channel cannot hide the checklist. Co-authored-by: Mathis <echobt@users.noreply.github.com> * fix(tui): import computer lock scenes after #71 rebase Co-authored-by: Mathis <echobt@users.noreply.github.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Mathis <echobt@users.noreply.github.com>
Summary
One draft PR for Designer-cli Already designed lock_v2 scenes on the CLI surface (Chat · Code · Bot only). Rebased on
origin/main.Landed scenes:
theme-picker,handoff-confirm(40×12 and 120×40),session-forkinit-agentscustom-commandshooks-lifecycle/handoffopens the confirm picker (not the unsupported-command path). Stay keeps this CLI; Cortex Cloud keeps Chat · Code · Bot here and opens/jobs. Source-policy:modal.rsstays under the line/complexity targets.Designer cli: chrome LOCK on these scenes. Stays draft — do not undraft or merge until CI is green.
Linear: COR-18 · COR-225 · COR-227 · COR-228
Test plan
cargo fmt --all -- --checkpython3 scripts/readiness/quality.py --base origin/maincargo test --no-default-features -p cortex-tui --lib ux_contract_handoff./scripts/clippy.sh(CI)cargo audit(CI)Attestation (required)
I attest that:
/handoffopens the confirm picker..envfiles are included.Risk
Visual-lock / TUI chrome plus
/handoffsession command. Stays draft.