Skip to content

Jackson upgrade - #3899

Open
shroffk wants to merge 47 commits into
masterfrom
jackson-upgrade
Open

shroffk wants to merge 47 commits into
masterfrom
jackson-upgrade

Conversation

@shroffk

@shroffk shroffk commented Jul 31, 2026

Copy link
Copy Markdown
Member

Summary

This PR upgrades JSON and search client dependencies and applies the required code updates for compatibility.

Changes

  • Upgraded Jackson dependencies to tools.jackson coordinates.
  • Fixed ObjectMapper configuration/usage to align with the upgraded Jackson stack.
  • Upgraded Elasticsearch client dependency and updated related client usage.

Why???

This is all to prepare for the JDK25 migration
#3839

Checklist

  • Testing:

    • The feature has automated tests
    • Tests were run
    • If not, explain how you tested your changes
  • Documentation:

    • The feature is documented
    • The documentation is up to date
    • Release notes:
      • Added an entry if the change is breaking or significant
      • Added an entry when adding a new feature

@shroffk

shroffk commented Jul 31, 2026

Copy link
Copy Markdown
Member Author

I have used the following to guide the changes

https://github.com/FasterXML/jackson/blob/main/jackson3/MIGRATING_TO_JACKSON_3.md

@shroffk
shroffk marked this pull request as draft July 31, 2026 19:26
@shroffk
shroffk marked this pull request as ready for review August 6, 2026 13:44
@shroffk shroffk mentioned this pull request Aug 6, 2026
6 tasks
@shroffk shroffk mentioned this pull request Aug 10, 2026
6 tasks
@shroffk

shroffk commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts in this pull request

# Conflicts:
#	app/channel/views/src/test/java/org/phoebus/channel/views/ui/ChannelTableDemo.java
#	app/channel/views/src/test/java/org/phoebus/channel/views/ui/ChannelTreeDemo.java
#	app/save-and-restore/model/src/main/java/org/phoebus/applications/saveandrestore/model/json/VTypeDeserializer.java

Co-authored-by: shroffk <2111304+shroffk@users.noreply.github.com>

Copilot AI commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Merged origin/master into the branch and resolved all conflicts:

  • ChannelTableDemo.java — kept the Jackson 3 (tools.jackson / JsonMapper) version
  • ChannelTreeDemo.java — kept the InputStream-based approach compatible with Jackson 3
  • VTypeDeserializer.java — kept JacksonException (required by Jackson 3's StdDeserializer)

@github-advanced-security github-advanced-security AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarCloud found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
7.8% Duplication on New Code (required ≤ 3%)
B Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@georgweiss

Copy link
Copy Markdown
Collaborator

@shroffk, having issues with embedded LDAP in save&restore. Need to fix this.

@georgweiss

Copy link
Copy Markdown
Collaborator

@shroffk, copying the implementation in Olog: that was painstakingly converted to Spring Boot 3.x, and seems to be working in 4.x. Also comes with the advantage of supporting multiple authentication providers.

@shroffk

shroffk commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

@georgweiss thanks... were you able to add the changed to this branch

@georgweiss

georgweiss commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Not quite done, so have not tried yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants