Repository navigation
fix(mob): stop retrying older messages in a loop after a failure - #175
Merged
mrsumanbiswas merged 1 commit intoNov 7, 2026
Conversation
A failed page load rebuilt the list, and the scroll listener asked for the same page again straight away, about 10 requests a second for as long as the chat stayed open. After a failure, stop paging until the chat is reopened. Closes CommandLineCoding#174
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #174.
When
GET /api/messages?with=…failed on Elephant Cloud (500 because migration 012 was missing on the production database), an open chat sent about 10 requests per second: 106 in 10 s, measured on a phone with logcat. Each failure rannotifyListeners(), the rebuild hit the scroll listener's "near the top" check, and that calledloadMoreMessages()again.Now a failed page sets
hasMoreMessages = false. Paging resumes when the chat is reopened, becauseopenChatresets it.flutter analyzeandflutter testpass.