Skip to content

fix(mob): keep HTTPS on while typing a port that starts with 80 #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrsumanbiswas merged 1 commit into from
Nov 7, 2026
Merged

fix(mob): keep HTTPS on while typing a port that starts with 80 #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions mobile/lib/pages/settings/server_settings.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ class _ServerSettingsFormState extends State<_ServerSettingsForm> {
text: Env.port,
);
late bool _tls = Env.useTls;

/// Set once the user flips the switch; until then it follows the port.
bool _tlsChosen = false;
_Health _health = _Health.unknown;

@override
Expand All @@ -43,12 +46,11 @@ class _ServerSettingsFormState extends State<_ServerSettingsForm> {
super.dispose();
}

/// Port 80 almost always means no TLS and 443 always means TLS, so
/// follow the port when it's one of those; otherwise keep the choice.
/// Port 80 almost always means no TLS, so follow the port until the user
/// chooses. Uses the whole port, so typing 8080 doesn't stop at "80".
void _onPortChanged(String port) {
setState(() {
if (port == '80') _tls = false;
if (port == '443') _tls = true;
if (!_tlsChosen) _tls = port != '80';
_health = _Health.unknown;
});
}
Expand Down Expand Up @@ -151,6 +153,7 @@ class _ServerSettingsFormState extends State<_ServerSettingsForm> {
value: _tls,
onChanged: (value) => setState(() {
_tls = value;
_tlsChosen = true;
_health = _Health.unknown;
}),
title: const Text('Use HTTPS/WSS'),
Expand Down
Loading