Repository navigation
FIX: select the next row after a delete, bound the folder tree and test every file operation - #91
Merged
Merged
Conversation
…st every file operation After the user deletes the selection, the reload selects the row that took its place, in folders and in search results. The rule is armed only by a delete made in rexplorer, for that tab and folder, and never on Home: any other reload leaves nothing selected when the selected items are gone, so a row the user never chose cannot take their next key. The folder tree no longer makes navigation wait: its sync runs from a timer, it expands only quick local paths (no reparse point on the way, no network, removable or optical drive, no virtual folder below the known roots), and it follows Explorer's "Expand to open folder" option. The sidebar gets a This PC row. A tab released just outside another rexplorer window's visible frame opens a new window instead of landing in that window. Multi-volume .rar sets are tested from committed fixtures. Every file operation has an automated check against the shell's own engine, including the conflict dialog's Skip and Replace, cancel, and New > Text Document.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First batch of the open v1.0 issues that need no hardware, no Windows setting and no install. Changes are under Unreleased in the changelog; the crate version stays 1.0.0-rc.2.
Changes
Deletedinnav.rs, armed inlist.rsverb_on_selection), for that tab and folder, within 10 seconds, and never on Home. A delete cancelled in the confirmation disarms it. Every other reload still selects nothing when the selected items are gone.lands_onininstance.rs).crates/core/tests/data_ops.rshas an automated check for every file operation against the shell's own engine: delete, move, rename, paste and drop with the conflict dialog's Replace and Skip, Keep both, cancel, archive extraction, and New > Folder and New > Text Document.build-testjob has a 25-minute limit.How it was tested
cargo build --release --locked --all-targetswith-D warnings,cargo test --release --lockedthree times (app 264, core 246, data_ops 11),cargo clippy --workspace --all-targets --locked -- -D warnings, andscripts\smoke.ps1 -Hosted(0 FAIL). The folder tree tests ran 40 more times and the core suite 6 more times without a failure.Not done
Issues
Closes #43, closes #26, closes #87.
Progress on #88. Tracking: #71.