Repository navigation
Write keygrabber samples to several named sinks, and add an OTLP sink for Prometheus - #51
Open
mikelangmayr wants to merge 2 commits into
Open
mikelangmayr wants to merge 2 commits into
mikelangmayr wants to merge 2 commits into
Conversation
prkrtg
reviewed
Nov 5, 2026
Collaborator
There was a problem hiding this comment.
Since _track_sink_health is removed, I don't think anything calls this set method
Collaborator
Author
There was a problem hiding this comment.
Removed, thanks.
| f"{label} exports to OTEL_EXPORTER_OTLP_ENDPOINT, which is unset; " | ||
| "set it in otel.env") | ||
| timeout_s = None | ||
| if "timeout_s" in sink_config: |
Collaborator
There was a problem hiding this comment.
Might be good to also check for unknown sinks
Collaborator
Author
There was a problem hiding this comment.
Unknown types were already refused; unknown keys in a sink are now too.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sink:becomes a namedsinks:map; every sample goes to each sink from one read; the old key is refused with a pointer to the new shape<sink>.isconnected,pointswritten,writeerrors,queuedepth,droppedbatches); the unprefixed ones report the aggregateotlpsink: numeric and bool keywords aslibby_keywordgauges stamped with their read time, exported toOTEL_EXPORTER_OTLP_ENDPOINT