Repository navigation
[03/29] Integrate the adopted upstream instrument baseline - #12
Merged
Merged
Conversation
Update Master for compiliing new MICADO package
Release MICADO 2023-03-08
Summer 2023 release
Mostly updates to MICADO package
Mostly adaption following the off-by-one fix
Prepare for new package release
Merge dev_master in preparation for release
Merge dev_master in preparation for release
Merge dev_master in preparation for release
Using best-guess values for MICADO, for METIS taken from: AstarVienna#356 (comment) Closes AstarVienna#356, except the LMS extended mode, which is not yet implemented anyway (also set the status to concept for that).
The additional diff comes from stripped whitespace or newlines.
…dded TEL.area default to MICADO MCA mode.
These allow the "full detector array" mode to be a "first-order- configurable", i.e. can be set via `properties`, instead of having to switch the `.include` on the two effects after instantiating the optical train. The latter still works, so this is fully backwards compatible.
Otherwise build hangs...
Resolve configured detector references, supply commands to analytical traces and detector headers, and include configured avalanche photon variance. Use 90,000 samples per region for the sparse dark-only Poisson check.
Add a 4096-pixel H4RG K detector mode
…zimager-instrument [28/29] Configure ZImager optics, filters and stochastic detector readouts
…alternate-detectors [14/29] Configure editable ZShooter detector alternatives and operating points
…zshooter-prescription [13/29] Adopt the selected ZShooter optical prescription and physical slit settings
…xshooter-instrument [12/29] Configure full-frame X-shooter spectroscopy and detector readouts
…xshooter-calibrations [11/29] Add attributed X-shooter calibration inputs and preparation calculations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge the already-adopted IRDB baseline through 518f19b and retain the HAWKI default-mode and MOSAIC instrument-header repairs.
Part 03/29 of the Caltech review series. Review the diff against
dev_master; the final destination isdev_master.Merge after series 02: scopesim.
Review focus: HAWKI/default.yaml; MOSAIC/default.yaml; adopted upstream package changes.
Validation: Adopted merge ancestry and final package differences inspected. Retained HAWKI/MOSAIC executed evidence is included in series 26.
Source commits/snapshots:
518f19b,b2cb0c9,72d360a (HAWKI),8be3e2c.Use a merge commit to preserve the stack ancestry and pinned commits. After this merges, retarget the next PR in this repository to its default branch. Do not squash/rebase an earlier stack entry without rebuilding its descendants and dependency pins.