Repository navigation
Review/XS 06 to 10 and zi-27 into main (stack up to 06 already merged) - #32
Merged
Merged
Conversation
…zimager-throughput [27/29] Apply imaging branch throughput before wavelength integration
…detector-operating-points [10/29] Model configured avalanche noise and warn at detector exposure limits
…slit-projection [09/29] Integrate slit illumination and detector pixels with pre-slit ADC shifts
…spectral-integrals [08/29] Preserve native spectral photon integrals and source representations
…calibrated-traces [07/29] Use calibrated traces and physical slit and detector coordinates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approving and merging into main for now.
PSF, shifts and echelle features are well isolated.
Features that affect optical train, fov, fov-manager, will need re-working before contributing to upstream.
Fix to make zimager work (source copying in selector wheel, dichroic tree, etc.) should be refactored as well, will do that later.