Skip to content

slicecamd: log the fine-acquire offset in arcsec on the guiding path - #513

Open
cfremling wants to merge 1 commit into
mainfrom
fix/slicecam-offset-log-arcsec
Open

cfremling wants to merge 1 commit into
mainfrom
fix/slicecam-offset-log-arcsec

Conversation

@cfremling

Copy link
Copy Markdown
Collaborator

offset_acam_goal takes the offsets in degrees. Only the not-guiding path converts them to arcsec (for the PT command) before the log line, so while ACAM guides, "requested offsets dRA=.. dDEC=.. arcsec" printed degrees. The log now prints arcsec on both paths. Log only; nothing else changes.

Rebuild, restart slicecamd. Tested on sky using branch cf/summit-20261030 on 2026-11-03.

🤖 Generated with Claude Code

offset_acam_goal takes the offsets in degrees. Only the not-guiding path
converts them to arcsec (for the PT command) before the log line, so while
ACAM guides the line "requested offsets ... arcsec" printed degrees. The log
now prints the offsets converted to arcsec on both paths.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-05T18:57:08.879538Z
We couldn’t complete this review. Comment @codex review to try again.
ec51757 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants