Repository navigation
Conversation
…n on every state update) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TargetInfomatched the integer keys withlike(OBSERVATION_ID like :obsid,SET_ID like :setid), which casts the column and defeats the primary key. EXPLAIN gives type=ALL, 93102 rows, for both the SELECT and the UPDATE inupdate_state, so every target-state write took ~215 ms instead of ~1 ms. Changed to=in the four conditions; EXPLAIN becomes const/range on PRIMARY, 1 row, with int or string binds.SET_NAME likeandSTATE likeare unchanged.This slow write is what made the EXPOSE-bit race fixed in #485 hit every bias; each PR stands alone.
Rebuild, restart sequencerd. Tested on sky using branch cf/summit-20261030 on 2026-11-03.
Jira: PAL-164.
🤖 Generated with Claude Code