Repository navigation
Conversation
EXPTIME is written in msec ("exptime" command, and per frame at the
expose), but stop_exposure overwrote it with the elapsed time in seconds,
so a frame stopped early carried EXPTIME 1000 times too small, as a
float. It now writes the elapsed time in msec. do_modify_exptime already
wrote msec; only its FITS comment said sec.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EXPTIME is in msec everywhere in camerad (the
exptimecommand; the per-frame write at the expose; ARC's exposure unit is fixed to msec), butstop_exposureoverwrote it with the elapsed time in seconds, as a float. A frame stopped early (seq stop, an operator stop mid-exposure) therefore carried an EXPTIME 1000 times too small. It now writes the elapsed time in msec.do_modify_exptimealready wrote msec; only its FITS comment said sec.Applies to main on its own; rebuild and restart camerad. Test: stop an exposure mid-way (at least 5 s before its end); EXPTIME is the elapsed time in msec (about 138000 for a stop after 138 s), not about 138.
Jira: PAL-188. Not yet tested on sky.
🤖 Generated with Claude Code