Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…mes out do_slicecam_fineacquire gave up waiting at ACQUIRE_TIMEOUT but never sent "fineacquire stop", so slicecamd's run went on until the next slew stopped it (move_to_target stops fine acquisition before moving). After a timeout in manual observing, "continue" therefore exposed while slicecamd kept moving the telescope: 2026-08-12, timeout 03:39:28, WTP18aaipkr exposing from 03:39:54, corrections at 03:40:00 and 03:40:32 and a lock at 03:40:47, stopped only at 04:19:22. An abort does not stop it either (it does so only inside the fine-acquire wait), and a repeat target never slews. The timeout branch now stops it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cfremling
force-pushed
the
fix/sequencer-stop-fineacquire-on-timeout
branch
from
October 29, 2026 14:09
3b83640 to
8f01252
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do_slicecam_fineacquiregave up waiting at ACQUIRE_TIMEOUT but never sentfineacquire stop, so slicecamd's run went on until the next slew stopped it (move_to_target stops fine acquisition before moving). After a timeout in manual observing,continuetherefore exposed while slicecamd kept moving the telescope: 2026-08-12, timeout 03:39:28, WTP18aaipkr exposing from 03:39:54, corrections at 03:40:00 and 03:40:32 and a lock at 03:40:47, stopped only at 04:19:22. An abort does not stop it either (it does so only inside the fine-acquire wait), and a repeat target never slews.The timeout branch now stops it. This is the core of #453, which also locked user moves during the ACAM acquire; that part is not carried here, and #453 is closed in favour of this PR.
Jira: PAL-183. Tested on sky using branch cf/summit-20261030 on 2026-11-03: the night's one fine-acquire timeout (10:03:35 UT) sent
fineacquire stopin the same millisecond, before the sequencer waited for the user.🤖 Generated with Claude Code