Repository navigation
fix: made HISTORY_IGNORE actually filter history - #66
Merged
Merged
Conversation
- Fixed history filtering: zsh never read `HIST_IGNORE`, so `cd` and `ls` have always been saved to history since #40. Renamed it to zsh's `HISTORY_IGNORE` with pattern syntax `(cd|ls|exit)` and added `exit`. It matches the whole line, so bare `ls` is skipped while `ls -la` is still recorded. Verified with `print -s` + `fc -W` in a clean `zsh -f`. - Dropped `MYSQL_HISTFILE` and `PGDATABASE` (from #48): neither `mysql` nor `psql` is installed on the host since #59 moved dev tools to Docker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HIST_IGNORE, socdandlshave always been saved to history since Don't record cd & ls commands in history #40. Renamed it to zsh'sHISTORY_IGNOREwith pattern syntax(cd|ls|exit)and addedexit. It matches the whole line, so barelsis skipped whilels -lais still recorded. Verified withprint -s+fc -Win a cleanzsh -f.MYSQL_HISTFILEandPGDATABASE(from Set default psql db #48): neithermysqlnorpsqlis installed on the host since chore: drop brew dev tool config in favor of Docker #59 moved dev tools to Docker.