Skip to content

ci: remove sudo and env from Install Composer Dependencies - #33

Merged
TheWitness merged 1 commit into
mainfrom
ci/permissions
Sep 14, 2026
Merged

TheWitness merged 1 commit into
mainfrom
ci/permissions

Conversation

@TheWitness

Copy link
Copy Markdown
Member

Summary

  • Removes sudo from all composer calls in the Install Composer Dependencies step. sudo composer * was producing warning messages during the CI workflow run.
  • Removes the env: block (COMPOSER_ROOT_VERSION: 1.3.0-dev) from the same step. This was previously needed to let Composer resolve dev-branch constraints, but is no longer required now that the missing dev dependencies (pestphp/pest, pestphp/pest-plugin-drift) are being added directly to the installed Cacti version's composer.json, so we no longer need to check out the develop version to get them.

Changes

  • .github/workflows/plugin-ci-workflow.yml: updated Install Composer Dependencies step.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified.

Pull request overview

Simplifies Composer dependency installation in the CI workflow.

Changes:

  • Removes sudo from Composer commands.
  • Removes the obsolete COMPOSER_ROOT_VERSION environment setting.
File summaries
File Description
.github/workflows/plugin-ci-workflow.yml Simplifies Composer dependency installation.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@TheWitness
TheWitness merged commit f7fc2f1 into main Sep 14, 2026
4 checks passed
@TheWitness
TheWitness deleted the ci/permissions branch September 14, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants