Repository navigation
fix: fail closed and bound semantic search execution - #126
Closed
afoote-mitre wants to merge 5 commits into
Closed
afoote-mitre wants to merge 5 commits into
afoote-mitre wants to merge 5 commits into
Conversation
This was referenced Aug 5, 2026
afoote-mitre
force-pushed
the
af/0.4.0-review-05-contracts
branch
from
August 5, 2026 13:17
a50d4df to
64ce9c3
Compare
afoote-mitre
force-pushed
the
af/0.4.0-review-05-contracts
branch
from
August 5, 2026 13:25
64ce9c3 to
b140e65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
5 of 6 in the
0.4.0review stack.af/0.4.0-review-04-search-runtimeWhy These Changes Are Needed
Later review found remaining fail-open edges in upstream response handling and query construction, plus CPU/event-loop risk in semantic CPE evaluation. This range closes those paths, bounds semantic work more tightly, and makes asynchronous startup and event-loop pressure observable.
Review Size
Changed lines are additions plus deletions in this PR's adjacent diff. Generated files are
package-lock.jsonandapi-docs/openapi.json; tests are*.test.jsand files undertest/.Change-to-File Map
utils/searchResponseValidator.js,utils/searchCandidateProcessor.js,controllers/searchController.jsutils/searchQueryBuilder.js,controllers/searchController.jsutils/searchQueryBuilder.test.js,controllers/searchController.test.jsutils/searchCandidateProcessor.js,utils/cpe.js,utils/searchPostFilterCache.jsserver.jsserver.test.jsutils/searchPerformance.js,config/default.jsoncutils/searchPerformance.test.jsREADME.md,.github/dependabot.yml,test/delivery-policy.test.jstest/delivery-policy.test.jsReviewer Focus