Repository navigation
refactor: centralize search validation and runtime controls - #124
Closed
afoote-mitre wants to merge 6 commits into
Closed
afoote-mitre wants to merge 6 commits into
afoote-mitre wants to merge 6 commits into
Conversation
This was referenced Aug 5, 2026
afoote-mitre
force-pushed
the
af/0.4.0-review-03-validation
branch
from
August 5, 2026 13:17
af920ee to
5d0ac93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
3 of 6 in the
0.4.0review stack.af/0.4.0-review-02-runtimeWhy These Changes Are Needed
The application still had legacy search fallbacks and configuration reads spread across request paths. Semantic CPE processing also needed incremental validation so one malformed or incompatible candidate could not contaminate later applicability decisions. This range centralizes those responsibilities and adds explicit application-level resource controls.
Review Size
Changed lines are additions plus deletions in this PR's adjacent diff. Generated files are
package-lock.jsonandapi-docs/openapi.json; tests are*.test.jsand files undertest/.Change-to-File Map
controllers/searchController.js,utils/searchProvider.js,utils/searchQueryBuilder.jsutils/searchCandidateProcessor.js,utils/searchResponseValidator.js,controllers/searchController.jsutils/searchCandidateProcessor.test.js,controllers/searchController.test.jsvirtualMatchStringinputs before querying.utils/cveId.js,controllers/middleware.js,utils/cpe.js,utils/searchQueryBuilder.jsutils/cveId.test.js,controllers/middleware.test.js,utils/cpe.test.js,utils/searchQueryBuilder.test.jscpeMatchentries from combining into a false match.utils/cpe.js,utils/searchCandidateProcessor.js,controllers/searchController.jsutils/cpe.test.js,utils/searchCandidateProcessor.test.js,controllers/searchController.test.jsutils/runtimeConfig.js,utils/featureFlags.js,utils/requestLogging.js,utils/searchProvider.js,server.js,config/*.jsoncserver.test.js,config/runtime-config.test.jsutils/searchRateLimiter.js,utils/constants.js,utils/searchDeadline.js,routes/index.js,server.jsutils/searchRateLimiter.test.js, route/server/middleware/controller testsDockerfile,Dockerfile.local,.env.exampleconfig/runtime-config.test.jsREADME.md,routes/swagger.js,api-docs/openapi.jsonapi-docs/openapi.test.jsReviewer Focus
cpeMatchentry.