Repository navigation
fix: harden search contracts and semantic resource controls - #122
Closed
afoote-mitre wants to merge 5 commits into
Closed
afoote-mitre wants to merge 5 commits into
afoote-mitre wants to merge 5 commits into
Conversation
afoote-mitre
force-pushed
the
af/0.4.0-review-01-dependencies
branch
from
August 5, 2026 13:17
4e89527 to
e852140
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
1 of 6 in the
0.4.0review stack.devMerge the stack in order. Each later PR is based on the branch immediately before it.
Why These Changes Are Needed
The existing search path trusted incomplete OpenSearch responses, accepted ambiguous structured filters, exposed inconsistent pagination/response behavior, and allowed expensive semantic CPE searches to consume unbounded application work. This first range establishes fail-closed search contracts and the initial resource boundaries before lifecycle and delivery changes are layered on top.
Review Size
Changed lines are additions plus deletions in this PR's adjacent diff. Generated files are
package-lock.jsonandapi-docs/openapi.json; tests are*.test.jsand files undertest/.Change-to-File Map
utils/searchProvider.js,controllers/searchController.js,utils/errors.jsutils/searchProvider.test.js,controllers/searchController.test.js,utils/errors.test.jscontrollers/middleware.js,utils/cvss.js,utils/cpe.js,utils/constants.jscontrollers/middleware.test.js,utils/cvss.test.js,utils/cpe.test.js,routes/cpeName.test.jscontrollers/searchController.js,routes/index.js,utils/searchQueryBuilder.js,routes/swagger.jscontrollers/searchController.test.js,routes/search.integration.test.js,utils/searchQueryBuilder.test.js,api-docs/openapi.test.jsutils/searchDeadline.js,utils/searchInFlightRegistry.js,utils/searchPostFilterCache.js,utils/searchPerformance.js,controllers/searchController.jsutils/*.test.jssuites andcontrollers/searchController.test.js.gitattributesREADME.md,routes/swagger.js,api-docs/openapi.jsonapi-docs/openapi.test.jsReviewer Focus