Repository navigation
Make PIO selectable via CLI build - #745
Merged
Merged
Conversation
Thank you for submitting a pull request to the CABLE Project. Minor restructuring of `CMakeLists.txt` to make it more logical. The things that apply regardless of the library, which is the default config values, and the build flags are at the start. The branches for the library and non-library builds then encompass the rest of the build- when we build the library, we never want all the bells and whistles e.g. testing, NetCDF, PIO. - [x] Bug fix - [x] The new content is accessible and located in the appropriate section - [x] I have checked that links are valid and point to the intended content - [x] I have checked my code/text and corrected any misspellings - [x] Are the changes bitwise-compatible with the main branch? If working on an optional feature, are the results bitwise-compatible when this feature is off? If yes, copy benchcab output showing successful completion of the bitwise compatibility tests or equivalent results below this line. <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--746.org.readthedocs.build/en/746/ <!-- readthedocs-preview cable end -->
abhaasgoyal
approved these changes
Oct 21, 2026
Contributor
|
@Whyborn both changes look good to me, if you could re-run the |
Contributor
Author
|
@abhaasgoyal The CI was successful (bar the docs links, which always fails). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CABLE
Thank you for submitting a pull request to the CABLE Project.
Description
This allows ParallelIO to be optionally included, rather than silently included/excluded based on whether PIO is available and MPI is selected. Also updates the CI to test the
+mpi+piobuild (and a small typo fix).Type of change
Please delete options that are not relevant.
Checklist
Testing
📚 Documentation preview 📚: https://cable--745.org.readthedocs.build/en/745/