feature: support PUID/PGID to change user - #655
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by linuxserver.io to be able to change the user in an easier way. Default to root for now to not make this a breaking change in any way
Summary by cubic
Adds PUID/PGID support so the container can run as a non-root user, inspired by linuxserver.io. The app still defaults to running as root, so existing setups are unaffected.
entrypoint.shvalidates thatPUID/PGIDare numeric, remaps theconvertxuser to the given IDs, chowns/app/dataonly when mount ownership differs, and launches the app viagosu.PUID,PGID, andUMASKenvironment variables control the runtime user and file creation mask.gosuto the image and documented the new variables in the README and example compose file.Written for commit 59d94a7. Summary will update on new commits.