Skip to content

[BI-3053] Nominal observations saved incorrectly to db - #574

Open
HMS17 wants to merge 2 commits into
developfrom
bug/BI-3053
Open

HMS17 wants to merge 2 commits into
developfrom
bug/BI-3053

Conversation

@HMS17

@HMS17 HMS17 commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Description

Story: BI-3053 - Nominal observations saved incorrectly to db

Additional experiment utilities and changes to experiment and append workflows in order for nominal observation value casing to match that of database ontology term

Import preview will show the casing of file EXCEPT in one case during the append workflow. If the overwrite file has the same nominal value as associated with the original observation unit and just different casing, it will not be recognized as a mutated value and the casing will match that of the database ontology.

Upon import observation value casing should match that of database ontology term

Dependencies

bi-web: develop

Testing

Create a nominal observation variable with different forms of casing

  • Upload experiment where some values for nominal variable don’t match the ontology casing
  • Import preview observation value casing should match that of file
  • After import observation value casing should match that of ontology term

Append experiment where some values for nominal variable don’t match the ontology casing

  • Import preview preview observation value casing should match that of file EXCEPT for observation units that are the same nominal value as the original observation unit but with different casing, which will instead match database casing
  • Statistics should properly reflect new and mutated values (with nominal values that are the same as the original observation unit with just different casing not counting as mutated)
  • After import values should be successfully overwritten and observation value casing should match that of ontology term

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit and/or integration tests to cover this change or tests are not applicable
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth

@github-actions github-actions Bot added the bug Something isn't working label Oct 30, 2026
@HMS17
HMS17 marked this pull request as ready for review October 30, 2026 14:11
@HMS17
HMS17 requested review from a team and jloux-brapi and removed request for a team October 30, 2026 14:11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant