Repository navigation
Use binary COPY and paced batches for Breaking-IT metrics - #3
Merged
Merged
Conversation
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues jgaalen/k6#3 on the organization fork. Original commits, validation notes, and review history are available on that PR.
What?
Send metrics via binary COPY, pace steady-state batches and timestamp the four release binaries.
Review
Deployment requires binary COPY support in pg-proxy. The original review records a TLS configuration race in CLI integration tests. This feature overlaps the shutdown path in the separate BreakTest DB draft. Reconcile the two implementations and rerun the drain tests before merging the second change.