Repository navigation
Respect View Tree automatic scrolling preference - #291
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When “Scroll automatically” is unchecked, incoming results preserve the selected sampler and anchor the active tree or table viewport to its first visible result. Evicting older results therefore keeps the visible content in place. If the anchor disappears, the previous offset is clamped to the new content size, including after filtering.
Live validation following respects the checkbox. Automatic tree expansion is cleaned up during validation updates even when the table tab is active, while manually expanded branches are preserved.
Motivation and Context
Live validation previously selected and scrolled to the newest sampler even with automatic scrolling disabled, preventing users from inspecting an earlier result while a run continued.
This intentionally changes validation's default behavior: the checkbox defaults to off, including in existing plans without an enabled setting. Those plans no longer automatically select or expand new validation results. Enable “Scroll automatically” to follow the latest validation sampler. This makes the saved preference apply consistently to validation runs.
How Has This Been Tested?
./gradlew :src:components:test --tests org.apache.jmeter.visualizers.ViewResultsFullVisualizerTest :src:components:checkstyleMain :src:components:checkstyleTest autostyleCheck— passed; 64 tests, no failures or skips.git diff --check— passed.Types of changes
Checklist