Repository navigation
Correct upstream matcher, null rendering and admin documentation bugs - #1
Merged
Merged
Conversation
The five corrections in this branch made the Java differential suites fail by design, so CI could not pass. List each affected case in testdata/intended_differences.json. For a listed case the suite now requires Java to return its documented upstream result and BreakMock its documented corrected result, both exactly (the OpenAPI document by the SHA-256 values in PROVENANCE.json). All other cases are still compared for equality. A listed case fails if either side changes, so an upstream fix or a lost correction is reported. A build without the corrections fails exactly these five cases; with them, verify.py passes all 20 suite runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct five upstream WireMock bugs: false XPath predicates matching requests, present empty JSON arrays counting as absent,
toJson(null)emitting an empty string,/__admin/docs/returning 404, and the missing scenario-state operation in the OpenAPI specification.Adds regression coverage and migration notes. Matcher fixture records preserve Java's original expectations alongside explicit corrected BreakMock expectations. Live differential suites pin each intentional difference on both sides instead of reporting it as a failure.
Validation on the identical source tree:
go test -race ./...andgo vet ./...passed.main, which includes Speed up large JSON responses and refresh Java/Go benchmarks #2): all 20 suite runs pass. The five intended differences are listed intestdata/intended_differences.json; for each, the suite requires Java's documented upstream result and BreakMock's documented corrected result, exactly (the OpenAPI document by its SHA-256 inPROVENANCE.json). All other cases are still compared for equality. A build without these corrections fails exactly those five cases, so the check is not a filter.See
docs/UPSTREAM_BUG_FIXES.mdandtestdata/reports/upstream-bug-fixes/validation.jsonfor evidence and migration details.🤖 Generated with Claude Code