Skip to content

Correct upstream matcher, null rendering and admin documentation bugs - #1

Merged
jgaalen merged 3 commits into
mainfrom
fix/upstream-bug-corrections
Oct 13, 2026
Merged

jgaalen merged 3 commits into
mainfrom
fix/upstream-bug-corrections

Conversation

@jgaalen

@jgaalen jgaalen commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Correct five upstream WireMock bugs: false XPath predicates matching requests, present empty JSON arrays counting as absent, toJson(null) emitting an empty string, /__admin/docs/ returning 404, and the missing scenario-state operation in the OpenAPI specification.

Adds regression coverage and migration notes. Matcher fixture records preserve Java's original expectations alongside explicit corrected BreakMock expectations. Live differential suites pin each intentional difference on both sides instead of reporting it as a failure.

Validation on the identical source tree:

  • go test -race ./... and go vet ./... passed.
  • Docker build and all 11 Toxiproxy integration checks passed.
  • Java differential checks (after merging current main, which includes Speed up large JSON responses and refresh Java/Go benchmarks #2): all 20 suite runs pass. The five intended differences are listed in testdata/intended_differences.json; for each, the suite requires Java's documented upstream result and BreakMock's documented corrected result, exactly (the OpenAPI document by its SHA-256 in PROVENANCE.json). All other cases are still compared for equality. A build without these corrections fails exactly those five cases, so the check is not a filter.

See docs/UPSTREAM_BUG_FIXES.md and testdata/reports/upstream-bug-fixes/validation.json for evidence and migration details.

🤖 Generated with Claude Code

jgaalen and others added 3 commits October 12, 2026 16:32
The five corrections in this branch made the Java differential suites fail by
design, so CI could not pass. List each affected case in
testdata/intended_differences.json. For a listed case the suite now requires
Java to return its documented upstream result and BreakMock its documented
corrected result, both exactly (the OpenAPI document by the SHA-256 values in
PROVENANCE.json). All other cases are still compared for equality.

A listed case fails if either side changes, so an upstream fix or a lost
correction is reported. A build without the corrections fails exactly these
five cases; with them, verify.py passes all 20 suite runs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jgaalen
jgaalen merged commit 08e18e0 into main Oct 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant