fix(catalog): surface real extraction errors and self-heal CI labels - #68
Merged
Conversation
extractModelCatalog kept the first candidate failure private and threw a generic 'Could not evaluate model catalog', so a new minified bundle shape (e.g. the $R is not defined regression) required manual reproduction to diagnose. The error now names the missing binding. catalog-sync.yml failed to open catalog-break issues whenever the repo labels were missing (issues disabled at the time); the workflow now force-creates catalog-break and automation labels before every sync run.
Contributor
|
🎉 This PR is included in version 0.7.47 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two permanent hardenings for the fragile paths documented in AGENTS.md
1.
extractModelCatalogsurfaces the real eval errorPreviously every candidate span's failure was swallowed and the throw was a generic
Could not evaluate model catalog— the 1.40.1$R is not definedbreak required manual tarball reproduction to diagnose. Now the first candidate error is kept and appended:The catalog-break issue body will contain the actionable message directly. Regression-tested with a fixture referencing an unbindable identifier.
2.
catalog-sync.ymlself-heals thecatalog-break/automationlabelsThe break-issue flow hard-failed (
gh issue create→ exit 1) whenever the labels were missing, as happened when the repo had issues disabled. A new Ensure automation labels step runs before the sync and force-creates both labels. Guarded by arelease-workflow.test.tscase that asserts step existence and ordering (beforecatalog-sync-ci.ts).TDD: both behaviors written as failing tests first.
bun run checkgreen (155 tests).Note: touches
src/catalog.ts→ semantic-release will cut a patch (intendedfix(catalog)release path).