fix(release): only fix/feat/perf commits can cut a release - #58
Merged
Conversation
BrainerVirus
force-pushed
the
fix/release-loop-chore-gate
branch
from
September 2, 2026 13:31
5e30d99 to
94d4d67
Compare
BrainerVirus
enabled auto-merge (squash)
September 2, 2026 13:33
BrainerVirus
force-pushed
the
fix/release-loop-chore-gate
branch
from
September 2, 2026 13:38
94d4d67 to
45f9ada
Compare
The chore(scope) release gating added for catalog syncs made the post-release 'chore(release): sync manifests' merge releasable (it touches package.json/manifest.json), so every release spawned the next one in an infinite loop (0.7.5..0.7.36+). Restore fix/feat/perf-only subject matching: manifest-sync and catalog-sync chore commits are bookkeeping and never release.
BrainerVirus
force-pushed
the
fix/release-loop-chore-gate
branch
from
September 2, 2026 13:40
45f9ada to
0a6d095
Compare
Contributor
|
🎉 This PR is included in version 0.7.47 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop the infinite release loop
The
chore(scope)gating made the post-releasechore(release): sync manifests to v0.Xmerge releasable (it touchespackage.json+manifest.json), so every release spawned the next sync → release → sync → ... loop (0.7.5 → 0.7.36+ and climbing, one npm publish every ~1.5 min).Change
scripts/analyze-release-scope.ts: subject matching is againfix/feat/perfonly —chore(with or without a scope) never cuts a release. This matches the workflow-toolkit convention and keeps:chore(release)merges → no release (breaks the loop)chore(catalog)merges → no release until they carry a realfix(catalog)commitfix/feat) → release as beforeTest
analyze-release-scope.test.tsassertschore(catalog)+chore(release)commits touching product files yield{ level: null }.