Repository navigation
fix(configurator): replace local files with repo config symlinks, back them up, keep linking on errors - #374
Open
gmmcosta15 wants to merge 3 commits into
Open
gmmcosta15 wants to merge 3 commits into
gmmcosta15 wants to merge 3 commits into
Conversation
…k them up, keep linking on errors
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On every start,
ConfigManager.synclinks each RF50-Klipper config file into the printer's config folder. If a regular file already sat where a link belongs (a hand-copied cfg, a leftover from an older deploy, a local edit),_symlink_configraisedFileExistsError. That file stayed local, so repo fixes never reached it. Because a singletrywrapped the whole loop, every repo file after it was skipped too, on every boot, with only one error line in the log. A new cfg added to the repo could silently never reach Klipper.Changes
~/.rf50_backups/<path>.<timestamp>, same as thevariables.cfgrepair) and replaced with the link, so the repo config always wins.printer.cfg,variables.cfg,BlocksScreen.cfg) are unchanged.Motivation
The config folder is meant to mirror the repo on every start, so a local change cannot break a machine. One stray file defeated that and also blocked every later link, including new configs shipped with updates.
Tests
tests/util/test_configurator_unit.py: