Skip to content

fix(acp): report model context window - #16

Closed
yan-ad wants to merge 2 commits into
Blankeos:mainfrom
yan-ad:fix/acp-context-window
Closed

fix(acp): report model context window#16
yan-ad wants to merge 2 commits into
Blankeos:mainfrom
yan-ad:fix/acp-context-window

Conversation

@yan-ad

@yan-ad yan-ad commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Thread model context-window metadata through selectable model entries
  • Have ACP resolve context window from the loaded selectable catalog before falling back to discovery/custom provider lookup
  • Preserve effective-catalog snapshots with optional context-window metadata

Why

ACP could report the default 1.5k context for providers/models whose real context was already known by the model catalog, because that metadata was dropped before ACP session configuration. This affects providers generally.

Validation

  • cargo fmt
  • cargo test acp

@yan-ad
yan-ad marked this pull request as draft August 6, 2026 08:06
@yan-ad
yan-ad marked this pull request as ready for review August 31, 2026 08:03
@yan-ad

yan-ad commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #44. The fix/acp-context-window commits were merged into that branch in merge commit 0062927, reconciled with current main, documented in _docs/acp.mdx, and validated with the ACP/model-catalog test suites. Closing this PR so review can continue in #44.

@yan-ad yan-ad closed this Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant