Skip to content

fix(sol): decode Token-2022 unknown data as base64 - #9726

Draft
ralph-bitgo[bot] wants to merge 1 commit into
masterfrom
fix/CHALO-1512-token-2022-unknown-data
Draft

fix(sol): decode Token-2022 unknown data as base64#9726
ralph-bitgo[bot] wants to merge 1 commit into
masterfrom
fix/CHALO-1512-token-2022-unknown-data

Conversation

@ralph-bitgo

@ralph-bitgo ralph-bitgo Bot commented Sep 11, 2026

Copy link
Copy Markdown

What

  • Decode Token-2022 unknown instruction data as base64 in explainTransactionWasm.
  • Add a BurnChecked Token-2022 regression fixture covering the unknown-instruction path.

Why

Token-2022 BurnChecked instructions are emitted by @bitgo/wasm-solana as unknown instructions with base64 data. Decoding that data as base58 throws Non-base58 character, causing pending approval requests to return HTTP 500.

Tests

  • yarn unit-test --grep "Token-2022 BurnChecked"
  • yarn prettier --check src/lib/explainTransactionWasm.ts test/unit/explainTransactionWasm.ts
  • yarn build
  • Full sdk-coin-sol unit suite: 553 passing; 3 setup-gated failures because BITGOJS_TEST_PASSWORD is not configured.

Ticket: CHALO-1512

@ralph-bitgo
ralph-bitgo Bot force-pushed the fix/CHALO-1512-token-2022-unknown-data branch from e6204e5 to fb711d9 Compare September 11, 2026 22:56
@linear-code

linear-code Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

CHALO-1512

Decode unknown Token-2022 instruction data as base64 before checking
confidential-transfer discriminators.

This prevents BurnChecked pending approvals from throwing Non-base58
character during transaction explanation.

Ticket: CHALO-1512
Session-Id: b8d737f7-739a-42bb-81a7-a9fbaf1ec4a6
Task-Id: 6288c7bd-acc3-46ee-a0bf-b5f2d595384e
@ralph-bitgo
ralph-bitgo Bot force-pushed the fix/CHALO-1512-token-2022-unknown-data branch 2 times, most recently from 082e954 to 45fd36e Compare September 11, 2026 22:57
@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants