feat(abstract-utxo): add zec address codec with unified address support - #9725
Open
veetragjain wants to merge 1 commit into
Open
Conversation
Contributor
Contributor
|
|
veetragjain
marked this pull request as ready for review
September 11, 2026 14:32
| * (plain transparent, transparent-only UA, malformed, wrong network) | ||
| * throws, since it has no Orchard receiver to resolve. | ||
| */ | ||
| override decode(address: string, unifiedRecipientPreference: UnifiedRecipientPreference = 'transparent'): Uint8Array { |
Contributor
There was a problem hiding this comment.
shouldn't this be a constructor arg / class member instead? then you can pass in AddressCodec instances and the callers don't need to know the preference
Contributor
Author
There was a problem hiding this comment.
Changed it to constructor arg
veetragjain
force-pushed
the
veetragjain/cshld-1724-add-address-codec-with-zip-316-unified-address-support
branch
from
September 11, 2026 16:17
75f35e7 to
6bfe3a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CSHLD-1639