Repository navigation
Conversation
Auto-generated from release 2026.8.26
PR Summary by QodoPackage PowerShell 7.6.5 with enhanced Nerd Font console
AI Description
Diagram
High-Level Assessment
Files changed (7)
|
Code Review by Qodo
1. Nested options are ignored
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+32
to
+33
| REM Check if we are running in a specialized console that doesn't need re-config | ||
| if defined BEARSAMPP_SHELL goto skip_registry_config |
There was a problem hiding this comment.
1. Nested options are ignored 🐞 Bug ≡ Correctness
Because the BEARSAMPP_SHELL jump occurs before argument parsing, invoking this launcher from the PowerShell session it creates ignores the documented --title and --startingDirectory options. The nested shell consequently opens with the default title and current directory instead of the requested values.
Agent Prompt
## Issue description
Nested launcher invocations skip all supported option parsing because `BEARSAMPP_SHELL` jumps past the parser.
## Issue Context
The launched PowerShell inherits `BEARSAMPP_SHELL=1`, so this affects calls made from that shell.
## Fix Focus Areas
- bin/powershell7.6.5/powershell.bat[32-73]
- bin/powershell7.6.5/powershell.bat[158-172]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+66
to
+72
| REM If 'exit' or any other non-flag argument is passed, it might be intended for PowerShell | ||
| REM We check if it's 'exit' specifically to handle the -NoExit flag | ||
| if /i "%~1"=="exit" ( | ||
| set "NO_EXIT=0" | ||
| ) | ||
| shift | ||
| goto parse_args |
There was a problem hiding this comment.
2. Powershell arguments are discarded 🐞 Bug ≡ Correctness
Every argument other than the two launcher options and exit is shifted away without being saved, and the final pwsh.exe command contains no forwarded argument list. Calls such as `powershell.bat script.ps1 or powershell.bat -File script.ps1` therefore open an interactive shell without executing the requested script.
Agent Prompt
## Issue description
The launcher discards normal PowerShell arguments instead of forwarding them to `pwsh.exe`.
## Issue Context
Preserve launcher-specific options while retaining all other arguments with safe batch quoting, then append them to the final launch command without conflicting with the generated initialization command.
## Fix Focus Areas
- bin/powershell7.6.5/powershell.bat[48-72]
- bin/powershell7.6.5/powershell.bat[169-185]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+9
to
+10
| setlocal EnableDelayedExpansion | ||
| pushd "%CD%" |
There was a problem hiding this comment.
3. Exclamation marks corrupt paths 🐞 Bug ≡ Correctness
Delayed expansion is enabled while %CD% and %~2 are assigned and later expanded with !…!, so literal exclamation marks in a valid Windows working directory or --startingDirectory value are removed or interpreted as expansion delimiters. The generated Set-Location then targets a different path and shell startup fails to enter the requested directory.
Agent Prompt
## Issue description
Enabled delayed expansion corrupts directory and title values containing literal `!` characters.
## Issue Context
Batch parameter and environment expansion must preserve arbitrary valid Windows path characters while still supporting variables needed inside parenthesized blocks.
## Fix Focus Areas
- bin/powershell7.6.5/powershell.bat[9-14]
- bin/powershell7.6.5/powershell.bat[48-64]
- bin/powershell7.6.5/powershell.bat[97-100]
- bin/powershell7.6.5/powershell.bat[169-172]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+140
to
+143
| reg add "HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Console\TrueTypeFont" /v "000" /t REG_SZ /d "!FONT_NAME!" /f >nul 2>&1 | ||
| reg add "HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Console\TrueTypeFont" /v "0000" /t REG_SZ /d "!FONT_NAME!" /f >nul 2>&1 | ||
| reg add "HKCU\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Console\TrueTypeFont" /v "0" /t REG_SZ /d "!FONT_NAME!" /f >nul 2>&1 | ||
| reg add "HKCU\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Console\TrueTypeFont" /v "00" /t REG_SZ /d "!FONT_NAME!" /f >nul 2>&1 |
There was a problem hiding this comment.
4. Console font slots overwritten 🐞 Bug ☼ Reliability
Each launch forcibly replaces fixed machine-wide and per-user Console\TrueTypeFont values with the Bearsampp font. Existing fonts registered in those shared slots are lost, affecting console applications unrelated to this PowerShell bundle.
Agent Prompt
## Issue description
The launcher overwrites fixed shared console-font registry values and removes registrations owned by other software or the user.
## Issue Context
The launcher already writes a window-title-specific `FaceName`; any required TrueTypeFont registration should reuse an existing matching value or select an unused value without modifying unrelated entries.
## Fix Focus Areas
- bin/powershell7.6.5/powershell.bat[107-115]
- bin/powershell7.6.5/powershell.bat[134-144]
- bin/powershell7.6.5/config/register-fonts.ps1[109-116]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.